Skip to content

gh-116988: Remove duplicates of annotated_rhs in the Grammar#117004

Merged
pablogsal merged 2 commits into
python:mainfrom
Rexicon226:fix-issue-116988
Apr 24, 2024
Merged

gh-116988: Remove duplicates of annotated_rhs in the Grammar#117004
pablogsal merged 2 commits into
python:mainfrom
Rexicon226:fix-issue-116988

Conversation

@Rexicon226

@Rexicon226 Rexicon226 commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

closes: #116988

  • remove duplicates
  • reran make regen-pegen
  • adds a cast to _PyPegen_lookahead generation so it can be used with explicitly typed rules

@ghost

ghost commented Mar 19, 2024

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app

bedevere-app Bot commented Mar 19, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Rexicon226 Rexicon226 changed the title gh-116988: Remove duplicates of annoted_rhs in the Grammar gh-116988: Remove duplicates of annotated_rhs in the Grammar Mar 19, 2024

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lysnikolaou

Copy link
Copy Markdown
Member

The Tests / CIFuzz (memory) failure is unrelated.

@Rexicon226

Copy link
Copy Markdown
Contributor Author

bump + updated to master

@pablogsal pablogsal merged commit 9b280ab into python:main Apr 24, 2024
@Rexicon226 Rexicon226 deleted the fix-issue-116988 branch April 24, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify the Grammar

4 participants